add http status labels to s3nd_upload_bytes_total metric#56
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the s3nd_upload_bytes_total metric to include HTTP status labels and ensures it's observed for all requests, not just successful ones.
- Changes the metric from a simple Counter to a CounterVec with "code" and "reason" labels
- Moves the bytes counting logic to always execute regardless of upload outcome
- Groups metric observations with comments for better code organization
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
53d87cb to
a3c32a8
Compare
And always observe the value, even upon failure.
a3c32a8 to
2a29051
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And always observe the value, even upon failure.