Skip to content

add http status labels to s3nd_upload_bytes_total metric#56

Merged
jhoblitt merged 1 commit intomainfrom
IT-6370/upload-s3nd_upload_bytes_total-labels
Sep 10, 2025
Merged

add http status labels to s3nd_upload_bytes_total metric#56
jhoblitt merged 1 commit intomainfrom
IT-6370/upload-s3nd_upload_bytes_total-labels

Conversation

@jhoblitt
Copy link
Copy Markdown
Member

And always observe the value, even upon failure.

@jhoblitt jhoblitt requested a review from Copilot September 10, 2025 15:47
@jhoblitt jhoblitt self-assigned this Sep 10, 2025
@jhoblitt jhoblitt added the enhancement New feature or request label Sep 10, 2025
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modifies the s3nd_upload_bytes_total metric to include HTTP status labels and ensures it's observed for all requests, not just successful ones.

  • Changes the metric from a simple Counter to a CounterVec with "code" and "reason" labels
  • Moves the bytes counting logic to always execute regardless of upload outcome
  • Groups metric observations with comments for better code organization

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@jhoblitt jhoblitt force-pushed the IT-6370/upload-s3nd_upload_bytes_total-labels branch from 53d87cb to a3c32a8 Compare September 10, 2025 15:49
And always observe the value, even upon failure.
@jhoblitt jhoblitt force-pushed the IT-6370/upload-s3nd_upload_bytes_total-labels branch from a3c32a8 to 2a29051 Compare September 10, 2025 15:51
@jhoblitt jhoblitt merged commit bc147a0 into main Sep 10, 2025
18 checks passed
@jhoblitt jhoblitt deleted the IT-6370/upload-s3nd_upload_bytes_total-labels branch September 10, 2025 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants