Conversation
ktlim
force-pushed
the
tickets/DM-51490
branch
from
32bb242 to
5edaea3
Compare
ktlim
force-pushed
the
tickets/DM-51490
branch
from
f43b0c4 to
3b13c16
Compare
This may help with double notifications.
ktlim
force-pushed
the
tickets/DM-51490
branch
from
7b009cd to
8eb8d09
Compare
ktlim
force-pushed
the
tickets/DM-51490
branch
from
7956a83 to
400b14e
Compare
atanikan
reviewed
Feb 25, 2026
ktlim
force-pushed
the
tickets/DM-51490
branch
2 times, most recently
from
6adf19a to
3cd9e3e
Compare
If any ingestion in a batch fails, none of the batch is ingested, so we need to retry one-by-one, even for guiders. (We might have a mix of old guiders and new ones.) The on_ingest_failure() callback is not useful for the batch, though, since some of the files in the batch may actually be able to be ingested, so we only use it during the one-by-one retries. If there are any guiders that fail during the one-by-one retry, we delay the next retry for 0.5 seconds to see if we can get a science image to define the exposure record.
ktlim
force-pushed
the
tickets/DM-51490
branch
from
3cd9e3e to
82a1136
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a simplistic version that sorts guiders to the end, ingests them using the method in
obs_lsst, and places them back on the queue if they failed (so they can be retried hopefully after a non-guider image has appeared).