DM-54386: use on_exposure_record for visit definition, bump stack#79
Open
DM-54386: use on_exposure_record for visit definition, bump stack#79
Conversation
atanikan
commented
Apr 1, 2026
atanikan
commented
- Wire RawIngestTask.on_exposure_record to DefineVisitsTask.run([record]) per ctrl_oods/butlerAttendant (avoids per-detector define-visits batches).
- Remove post-batch visit_definer loop over success_refs.
- Default OBS_LSST_VERSION to w_2026_13 (DM-54297/DM-53882); align manual workflow default.
atanikan
force-pushed
the
tickets/DM-54386
branch
3 times, most recently
from
787db23 to
b54f649
Compare
- Wire RawIngestTask.on_exposure_record to DefineVisitsTask.run([record]) per ctrl_oods/butlerAttendant (avoids per-detector define-visits batches). - Remove post-batch visit_definer loop over success_refs. - Default OBS_LSST_VERSION to w_2026_13 (DM-54297/DM-53882); align manual workflow default.
atanikan
force-pushed
the
tickets/DM-54386
branch
from
b54f649 to
a512f2a
Compare
srp3rd
approved these changes
Apr 2, 2026
srp3rd
left a comment
srp3rd
left a comment
There was a problem hiding this comment.
Everything looks fine; didn't realize that you could have nested def's like that, callable outside the scope of the initial definition. TIL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.