DM-48647: Update ap_verify default to use ghcr #1067
Merged
Conversation
ktlim
reviewed
Apr 30, 2025
jobs/ap_verify.groovy
Outdated
| parameters { | ||
| stringParam('REF', null, 'Git "ref" of ap_verify to attempt to build. Default uses version in release docker image.') | ||
| stringParam('DOCKER_IMAGE', 'lsstsqre/centos:d_latest', 'Explicit name of release docker image including tag.') | ||
| stringParam('DOCKER_IMAGE', 'ghcr.io/lsst/scipipe', 'Explicit name of release docker image including tag.') |
Contributor
There was a problem hiding this comment.
I think this has to have a tag. d_latest should carry over.
ktlim
approved these changes
Apr 30, 2025
Contributor
ktlim
left a comment
ktlim
left a comment
There was a problem hiding this comment.
Please fix the tag, otherwise this is fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.