DM-54580: Add skymap viewer for the plan#40
Open
leannep wants to merge 23 commits intotickets/DM-52852from
Open
DM-54580: Add skymap viewer for the plan#40leannep wants to merge 23 commits intotickets/DM-52852from
leannep wants to merge 23 commits intotickets/DM-52852from
Conversation
added 11 commits
April 9, 2026 11:34
… skymap _get_band can determine the filter.
womullan
approved these changes
Apr 9, 2026
Contributor
womullan
left a comment
womullan
left a comment
There was a problem hiding this comment.
happy to see if we can deploy in my branch - dev is set up get the container for my branch already
scripts/render_skymap.py
Outdated
| _REPO_ROOT = pathlib.Path(__file__).parent.parent | ||
| sys.path.insert(0, str(_REPO_ROOT / "src")) | ||
|
|
||
| LIVE_URL = "https://usdf-rsp.slac.stanford.edu/obsloctap/schedule" |
Contributor
There was a problem hiding this comment.
should come from config with a default - so we can pass it in phalanx - see getHelper in db.py for example
| # Find matching obsplan entries | ||
| done = False | ||
| # simple case obs_id matches exposure_id | ||
| idmatch = await self.find_by_obs_id(exp.exposure_id, session) |
Contributor
There was a problem hiding this comment.
i see you adde this in the flake 8 config - i am hoping that will work ..
src/obsloctap/skymap.py
Outdated
| _COORD_SELECT_WIDTH = 300 | ||
| _TOGGLE_WIDTH = 155 | ||
|
|
||
| _GAL_TOGGLE_JS = """ |
Contributor
There was a problem hiding this comment.
should we consider putting all the Java Scrtpt in a .js file and import that to the generated page ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First version of a skymap viewer for the observing plan. There may be more updates to come.