DM-53502-weekly: Add ability to retire old weekly tags#17
Merged
Conversation
roceb
force-pushed
the
tickets/DM-53502-weekly
branch
2 times, most recently
from
ccfa23a to
8769f81
Compare
roceb
force-pushed
the
tickets/DM-53502-weekly
branch
from
8769f81 to
33098b5
Compare
mwittgen
requested changes
Dec 11, 2025
| } | ||
| // ISO week date format | ||
| // Get time for first day of the given year and week | ||
| t = time.Date(year, 0, 0, 0, 0, 0, 0, time.UTC) |
Contributor
There was a problem hiding this comment.
The Date function uses 1-12 for month and 1-31 for day.
Contributor
There was a problem hiding this comment.
Doesn't calculate the dates correctly. Maybe write a unit test?
https://go.dev/play/p/PVa_Z7-y6Zz
Contributor
Author
There was a problem hiding this comment.
Fixed the bug and added some error handling.
roceb
force-pushed
the
tickets/DM-53502-weekly
branch
2 times, most recently
from
7515d82 to
009ffcd
Compare
mwittgen
reviewed
Dec 12, 2025
mwittgen
reviewed
Dec 12, 2025
mwittgen
reviewed
Dec 12, 2025
| return t, err | ||
| } | ||
|
|
||
| func parse_w_tag(tag string) (t time.Time, err error) { |
Contributor
There was a problem hiding this comment.
This always returns a Monday with the exception of the first release in a year which is always Jan 1st.
Check for consistency.
roceb
force-pushed
the
tickets/DM-53502-weekly
branch
from
009ffcd to
33aa418
Compare
roceb
force-pushed
the
tickets/DM-53502-weekly
branch
from
33aa418 to
89b8e1b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.