Closed
Conversation
ktlim
commented
Aug 27, 2025
src/transfer_raw_zip.py
Outdated
| "torepo", | ||
| type=str, | ||
| help="Repository to which data is transferred.", | ||
| "torepos", |
Contributor
Author
There was a problem hiding this comment.
I would keep the name but add nargs="+" and not use comma_separated_list.
| key="arcBackup", | ||
| value="SLAC_RAW_DISK_BKUP:need", | ||
| ) | ||
| self.did_client.set_metadata( |
Contributor
Author
There was a problem hiding this comment.
Please make this a separate commit.
src/transfer_raw_zip.py
Outdated
Comment on lines
+729
to
+731
| for torepo in config.torepos: | ||
| dest_butler = Butler(torepo, writeable=True) | ||
| dest_butlers.append(dest_butler) |
Contributor
Author
There was a problem hiding this comment.
More compact is:
Suggested change
| for torepo in config.torepos: | |
| dest_butler = Butler(torepo, writeable=True) | |
| dest_butlers.append(dest_butler) | |
| dest_butlers = [Butler(torepo, writeable=True) for torepo in config.torepos] |
This should also solve the immediate test failure.
|
close and remake in the repo itself. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.