Add wet-001 optical state estimation json block notebooks #30
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
gmegh
force-pushed
the
tickets/SITCOM-1870
branch
from
e82e8e0 to
3c5c51f
Compare
| @@ -0,0 +1,222 @@ | |||
| { | |||
There was a problem hiding this comment.
Line #8. "day": {
Is this day_obs in butler terms? I think you should just name this day_obs and the next one to seq_num to make clear what they are asking for. Would also rephrase the description to "day and year". Or do you actually mean the "n'th" day of the year? I would suggest not doing that and using day_obs instead.
Reply via ReviewNB
| @@ -0,0 +1,222 @@ | |||
| { | |||
There was a problem hiding this comment.
Line #23. "maxiter": {
I Just noticed that we have out configurations all using snake case except this one in all the scripts. Maybe we should change to be consistent?
Reply via ReviewNB
| @@ -0,0 +1,222 @@ | |||
| { | |||
There was a problem hiding this comment.
Line #1. ranges = [150, 5000, 5000, 0.1, 0.1]
These ranges and test patterns should be added somewhere in Zephyr scale for reference.
Reply via ReviewNB
| @@ -0,0 +1,222 @@ | |||
| { | |||
There was a problem hiding this comment.
Line #8. name="maintel/set_dof.py",
Setting up set_dof.py like this requires a rewrite of set_dof.py right? Is that work recorded as a TODO somewhere and linked to this?
Reply via ReviewNB
| @@ -0,0 +1,222 @@ | |||
| { | |||
There was a problem hiding this comment.
| @@ -0,0 +1,221 @@ | |||
| { | |||
There was a problem hiding this comment.
| @@ -0,0 +1,232 @@ | |||
| { | |||
There was a problem hiding this comment.
No description provided.