DM-50298: Write configs when initializing new RUN collections.#117
Open
DM-50298: Write configs when initializing new RUN collections.#117
Conversation
| task = taskFactory.makeTask(taskNode, butler, inputRefs) | ||
|
|
||
| for writeEdge in taskNode.init.outputs.values(): | ||
| for writeEdge in taskNode.init.iter_all_outputs(): |
Contributor
There was a problem hiding this comment.
Only just noticed this, and just gave it a go, and it failed with errors like
Traceback (most recent call last):
File "/sdf/home/m/mfl/lsst/rubintv_production/tests/ci/test_rapid_analysis.py", line 719, in _exec_script
exec(script_content, exec_globals)
File "<string>", line 41, in <module>
File "/sdf/home/m/mfl/lsst/rubintv_production/python/lsst/rubintv/production/processingControl.py", line 632, in __init__
self.outputRun = self.getLatestRunAndPrep(forceNewRun=forceNewRun)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/sdf/home/m/mfl/lsst/rubintv_production/python/lsst/rubintv/production/processingControl.py", line 666, in getLatestRunAndPrep
latestRun = ensureRunCollection(
^^^^^^^^^^^^^^^^^^^^
File "/sdf/home/m/mfl/lsst/rubintv_production/python/lsst/rubintv/production/processingControl.py", line 167, in ensureRunCollection
getattr(task, writeEdge.connection_name),
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'IsrTaskLSST' object has no attribute '_config'. Did you mean: 'config'?
Any idea what's wrong there? I've not investigated, as I figured it'd likely be obvious to you.
Contributor
Author
There was a problem hiding this comment.
Just a bad first attempt by me. I've replaced that commit with a new one that I think should work.
0c72488 to
b308e92
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.