Skip to content

Add Control Loop Single and Double Exposure Notebook#35

Open
jbkalmbach wants to merge 1 commit intodevelopfrom
tickets/SITCOM-1521
Open

Add Control Loop Single and Double Exposure Notebook#35
jbkalmbach wants to merge 1 commit intodevelopfrom
tickets/SITCOM-1521

Conversation

@jbkalmbach
Copy link
Copy Markdown
Member

No description provided.

@jbkalmbach jbkalmbach marked this pull request as ready for review April 3, 2025 21:04
@review-notebook-app
Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@jbkalmbach jbkalmbach force-pushed the tickets/SITCOM-1521 branch from 1af78e1 to a287bcf Compare April 3, 2025 21:05
@jbkalmbach jbkalmbach requested review from gmegh and suberlak and removed request for gmegh April 3, 2025 21:06
@@ -0,0 +1,338 @@
{
Copy link
Copy Markdown
Contributor

@suberlak suberlak Apr 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line #2.    plt.plot((zk_table_30_sec['visit'] - zk_table_30_sec['visit'][0])/3, zk_table_30_sec['fwhm_combined'], label='30 Second Exposures')

Could you add any marker for the data so we see them?


Reply via ReviewNB

@@ -0,0 +1,338 @@
{
Copy link
Copy Markdown
Contributor

@suberlak suberlak Apr 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see an empty cell in TimesSquare at the end. Otherwise looks good!


Reply via ReviewNB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants