DM-54614: Add DP2 to TAP_SCHEMA#6415
Conversation
stvoutsin
left a comment
stvoutsin
left a comment
There was a problem hiding this comment.
Changes look correct to me, although you may want to rebase now that we updated the schema version + template in the base values, so you should only need to update the schemaVersion.
Other than that, do we want to verify that this is the order we want the schemas to appear in the portal (dp2 after dp1)?
rra
left a comment
rra
left a comment
There was a problem hiding this comment.
Looks okay to me as well, with the note about schema ordering.
JeremyMcCormick
force-pushed
the
tickets/DM-54614
branch
from
6c1ff81 to
4a49a7c
Compare
JeremyMcCormick
changed the title
JeremyMcCormick
force-pushed
the
tickets/DM-54614
branch
from
4a49a7c to
0eb82bb
Compare
| instanceConnectionName: "science-platform-int-dc5d:us-central1:science-platform-int-8f439af2" | ||
| serviceAccount: "tap-service@science-platform-int-dc5d.iam.gserviceaccount.com" | ||
| database: "tap" | ||
|
|
There was a problem hiding this comment.
This looks good for using the old containerized approach as discussed rather than the repertoire-managed TAP_SCHEMA. We can work through what is required to support the new sdm_schemas changes and then switch back to the new approach once that is resolved.
JeremyMcCormick
force-pushed
the
tickets/DM-54614
branch
from
0eb82bb to
985ca1e
Compare
JeremyMcCormick
force-pushed
the
tickets/DM-54614
branch
from
985ca1e to
afc66fb
Compare
|
|
||
| urlRewrite: | ||
| enabled: true | ||
| rules: "ivoa.ObsCore:access_url, dp02_dc2_catalogs.ObsCore:access_url, dp1.ObsCore:access_url" |
There was a problem hiding this comment.
If we have ObsCore under dp2 we'll also need to add dp2.ObsCore:access_url to this rule here for rewriting the URL of access_url
3 participants
These changes were based on the existing configuration for
dp1.