DM-39710: Patch create_app_client to preset JWT #182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes GitHubAppClientFactory.create_app_client. I mistakenly though that the oauth_token attribute on the GitHubAPI constructor could be used to cache the app's JWT. It turns out that the JWT is treated entirely separately, and currently can't be cached in GitHubAPI. Instead, the JWT needs to be passed to each request method. This commit achieves the desired behaviour by patching the Gidgethub GitHubAPI methods to always set the jwt keyword argument.
Rather than monkeypatch GitHubAPI to cache the JWT, it's type-safer to create a new class with new methods that work with app authentication and cached JWTs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes
GitHubAppClientFactory.create_app_client. I mistakenly though that the oauth_token attribute on the GitHubAPI constructor could be used to cache the app's JWT. It turns out that the JWT is treated entirely separately, and currently can't be cached in GitHubAPI. Instead, the JWT needs to be passed to each request method. This commit achieves the desired behaviour by patching the Gidgethub GitHubAPI methods to always set the jwt keyword argument.