Tickets/DM-52459: add donut_id

[suberlak]

Adding donut_id based on detector and donut brightness.

[jbkalmbach]

Why did you decide to make this a string instead of an int?

[jbkalmbach]

Remove blank line.

[jbkalmbach]

I think you could remove the blank line above this since it goes with testing the properties.

[jbkalmbach]

Do we care that the same donut could have different donut_id values in an extra-intra pair when running in full array mode? Probably not I think but can you think of any reason?

[suberlak]

I went along with a str because it allowed a possibility of making names like eg. 191_0001 or R00_191_0001 etc. But I could revert to int if you think it's better. It is possible to fold in a visit number (since I have access to exposure in generateDonutCatalogUtils.py), i.e. make it not only 2025053100117_191_0001, but 202505310011701910001 (eg. 4 spaces for detector and 4 spaces for donut for clearer reading)- that way we'd have visit-detector-donut granularity (i.e. possible to distinguish intra/extra when running in FAM mode since extra/intra have different visit number).

[jbkalmbach]

It looks like you need to add a test somewhere that verifies donut_id is output in the format you expect. I don't see a test for that anywhere.

[suberlak]

added test for donut_id

[jbkalmbach]

Thanks, looks good.