tickets/SP-3223: Add extinction and cloud stacker#523
Draft
ehneilsen wants to merge 3 commits into
Draft
Conversation
ehneilsen
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two stackers are added to maf here, intended to be applied to visit sequences from consdb queries rather than opsim output.
The first uses sklearn robust linear fitting tools to fit for photometric extinction and zero point given the the zero_point_median, band, and airmass columns from consdb.
The next uses the results of this and zero_point_median to estimate the extinction from clouds, falling back on rubin_sim.phot_utils.predicted_zeropoint if there was no good fit. It supports an optional offset, so you can (and I probably will) feed in rubin_nights.reference_values.ZEROPOINT_OFFSETS_LSSTCAM, which if I understand what's going on will replicate what rubin_sim_addons does.
This was developed with a mixture of hand-coding and claude code assistance using the experimental support of claude code at the USDF.