Open
Conversation
jdesfossez
reviewed
Apr 5, 2017
Contributor
jdesfossez
left a comment
jdesfossez
left a comment
There was a problem hiding this comment.
Just a few stylistic comments, but otherwise it looks good to me !
| } | ||
|
|
||
| static | ||
| int lttng_match_enabler_exclusion(const char *desc_name, |
tests/probes/lttng-test.c
Outdated
| i = 0; | ||
| prev_is_space = 1; | ||
| while (i < len && str[i] != '\0') { | ||
|
|
tests/probes/lttng-test.c
Outdated
| count = 0; | ||
| i = 0; | ||
| prev_is_space = 1; | ||
| while (i < len && str[i] != '\0') { |
Contributor
There was a problem hiding this comment.
I think it would be clearer like that:
for (i = 0; i < len && str[i] != '\0'; i++)
tests/probes/lttng-test.c
Outdated
| break; | ||
| } | ||
|
|
||
| i++; |
Contributor
There was a problem hiding this comment.
not needed if you use a for-loop instead of the while
tests/probes/lttng-test.c
Outdated
| * method and the string from the user | ||
| */ | ||
| ret = -EINVAL; | ||
| for (i = 0; i < ARRAY_SIZE(test_methods); i++) { |
Contributor
There was a problem hiding this comment.
2 spaces before ARRAY_SIZE
Signed-off-by: Francis Deslauriers <francis.deslauriers@efficios.com>
Signed-off-by: Francis Deslauriers <francis.deslauriers@efficios.com>
Contributor
Author
|
Thank you for the feedback, I addressed the style issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.