Skip to content

Select a random background image each time the site is built #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fgaz
Copy link
Contributor

@fgaz fgaz commented May 15, 2025

@wsor4035
Copy link
Contributor

i didnt think anyone was going to take my joke seriously, a sliding image background/carousel would probably be better. that said not opposed to this

@sfan5
Copy link
Contributor

sfan5 commented May 15, 2025

This doesn't make that much sense, since the site is statically built only once when changed.

@fgaz
Copy link
Contributor Author

fgaz commented May 15, 2025

since the site is statically built only once when changed

Yes, and by looking at the commit log I see that it happens fairly frequently (monthly at least). Throw in a bunch of different images and you get some variability without having to update the image manually every once in a while.

I agree a carousel would be better (even though there is already a gallery further down the page). This is a low-tech way to get some of that value with a fraction of the work

@Calinou
Copy link
Contributor

Calinou commented May 15, 2025

While I think randomizing the image on load via JavaScript is preferable, this is a fine solution too.

Copy link
Contributor

@wsor4035 wsor4035 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a serious review to a joke

be fine merging this, but literally no point if your only going to have one image, otherwise its just overhead/debt

@SmallJoker
Copy link
Member

SmallJoker commented May 17, 2025

but literally no point if your only going to have one image

I think it's a good preparation to proceed with screenshot debates in another PR. Adding code to support multiple backgrounds in the first place is a good idea. Also the change is straightforward and only needs a few lines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants