-
Notifications
You must be signed in to change notification settings - Fork 2.1k
[Adoption] Default physics variables #14859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
My whole point is to allow mods to modify the value. Without, it's pretty useless for me |
Done in 917345d. But I wonder if the following code is guaranteed to run before any mods: |
Wait, the change was already possibile without these commits. What I needed was simply a way to do |
Yeah, only the last commit is meaningful. I kept the previous commits only because I am too lazy to delete them. |
@Emojigit rebase needed |
3909797
to
32c0aa1
Compare
Co-authored-by: Yoruma <[email protected]>
32c0aa1
to
f31af15
Compare
I have no idea how to fix whitespaces.... |
This PR is an adoption of #14767. This PR adds a
minetest.DEFAULT_PHYSICS
table so mods know the default values. The table is compatible withset_physics_override()
.Closes #14764
To do
This PR is Ready for Review.
minetest.DEFAULT_PHYSICS
in Lua APIHow to test
Run the unit test
test_player_default_physics
in devtest.