Skip to content

Complete rename to Luanti in package metadata #16017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

appgurueu
Copy link
Contributor

Primarily preparations for a Flathub resubmission, but also renames the .desktop file and the AppImage.

Plan:

Resources:

Primarily preparations for a Flathub resubmission,
but also renames the `.desktop` file and the AppImage.
@appgurueu appgurueu added the Maintenance Tasks to keep the codebase and related parts in order, including architectural improvements label Apr 13, 2025
Copy link
Collaborator

@sfan5 sfan5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok

@sfan5
Copy link
Collaborator

sfan5 commented Apr 21, 2025

Can this be merged?

@sfan5 sfan5 added this to the 5.12.0 milestone Apr 21, 2025
@appgurueu
Copy link
Contributor Author

I think so. However it might be better to wait just until before we release 5.12 so I can open the PR https://github.com/flathub/flathub/compare/new-pr...appgurueu:flathub:new-pr?expand=1 against that then (so it goes merge this -> tag 5.12 -> submit PR pinning 5.12 to flathub).

@sfence
Copy link
Contributor

sfence commented Apr 21, 2025

Whitespace check should be updated to ignore XML files before the merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Tasks to keep the codebase and related parts in order, including architectural improvements One approval ✅ ◻️
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants