Add option to ignore Lua destructor test with warning

[twrightsman]

Some uncommon architectures (e.g. armel) fail the destructor test but users may still want to use them without disabling all unit tests.

This is a potential workaround for #16031 in situations where we want to ensure the other unit tests still pass.

To do

This PR is Ready for Review.

How to test

Add -DIGNORE_LUA_DESTRUCTOR_TEST_FAILURE=TRUE to cmake options and test on one of the known failing architectures: armel, armhf, loong64, or mips64el.

[sfan5]

I get the idea, but if you as a packager are conditionally enabling this option it should be equally easy to just patch the test out as needed.

[twrightsman]

should be equally easy

In theory, yes 🙂 Though Debian tooling favors the single patch for all architectures.

That being said, this patch really borders on being Debian-specific and I would completely understand if you decide this is something not appropriate to be included in Luanti upstream. A more general test skipping mechanism would probably be better.

[appgurueu]

A more general test skipping mechanism would probably be better.

I agree. We use Catch2 for new tests which could provide this. The problem currently just is that many tests don't use Catch2 yet. I have a patch which converts the tests in question to use Catch2: https://github.com/appgurueu/minetest/tree/test/lua

The problem is just that if we abuse --test-module '~[lua_destructors]', it will only run the Catch2 tests (because all non-Catch2 tests obviously aren't called ~[lua_destructors]).
For an intermediate solution, we could potentially just add another command line option.