added lua set_wield_index #16767
Open
added lua set_wield_index #16767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cx384
added
@ Script API
Feature ✨
Member
|
I'm not sure if we want the server to be able to do this, because of responsiveness. |
Author
|
@cx384 thank you for your feedback! I added the usecase to the description. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have ObjectRef:get_wield_index(), which returns the number of the item currently selected in the hotbar.
There is no ObjectRef:set_wield_index(index) yet, which is is added by this PR.
This method can be called by a server side mod, so a new network package is added to tell the client that it should change to the specified index.
To do
This PR is Ready for Review.
How to test
player:set_wield_index(3)Usecase
I am working on a mod which provides a radial menu. One usecase would be to support number keys and/or mouse wheel up/down for changing the current selection. This is already possible by hiding the wielded item and hotbar and temporarily replacing the inventory. The only problem is that the selected item should be restored when the menu is closed.
This PR provides the changes which are required to make this possible. There are no also no latency problems because this is rarely operation (and the selected index can be restored before showing the hotbar again, so the user will not notice it)