Skip to content

Don't frame as error when player is disconnected using core.disconnect_player #16814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
CrazyladMT wants to merge 1 commit into from
+1 −1
Closed

Don't frame as error when player is disconnected using core.disconnect_player #16814

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion builtin/fstk/ui.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ function ui.update()
if string.find(gamedata.errormessage, "ModError") then
error_title = fgettext("An error occurred in a Lua script:")
else
error_title = fgettext("An error occurred:")
error_title = fgettext("The server has denied access:")
Copy link
Member

@sfan5 sfan5 Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now we get the inverse bug: if some kind of error occurs, the dialog says "The server has denied access", which is a lie.

Copy link
Contributor Author

@CrazyladMT CrazyladMT Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is that needed in general, since the other text (which allows for a reason) already kinda says what's up...

end
formspec = {ui.get_message_formspec(error_title, error_message, "btn_error_confirm")}
ui.overridden = true
Expand Down
Loading