[no sq] Various improvements to the input handler #16815
Draft
+271
−283
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The order of the commits is more or less outlined in #16750 (comment). I chose to not open 4 pull requests as some commits (particularly the second commit) introduce changes that are obsoleted/removed in later ones.
KeyPress::scancodeis renamed toKeyPress::valueKeyPress::getType()is introduced to get the type of inputstd::variant-related functions and methods use indices (based ongetType()) instead of types; this makes it easier to infer the type of input.EKEY_CODEvariant is removed fromKeyPressas it is no longer neededTo do
This PR is a Work in Progress.
How to test
keymap_autoforward = KEY_MBUTTON) are automatically migrated (i.e. continue to work), and the user is not informed about the migration.