Skip to content

Add support for LUANTI_GAME_PATH and LUANTI_WORLD_PATH #16816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
apteryks wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add support for LUANTI_GAME_PATH and LUANTI_WORLD_PATH #16816

apteryks wants to merge 1 commit into from
+47 −16

Conversation

@apteryks
Copy link

@apteryks apteryks commented Jan 8, 2026

  • src/content/subgames.cpp (getSubgamePathEnv): Deprecate MINETEST_SUBGAME_PATH in favor of LUANTI_GAME_PATH. (getWorldPathEnv): Deprecate MINETEST_WORLD_PATH in favor of LUANTI_WORLD_PATH.

Add compact, short information about your PR for easier understanding:

  • Goal of the PR: Use LUANTI named environment variables, upstreaming a patch used in Guix.
  • How does the PR work? Tested with Guix; it works well.
  • Does it resolve any reported issue? No.
  • Does this relate to a goal in the roadmap? No.
  • If not a bug fix, why is this PR needed? What usecases does it solve?
    Naming consistency.
  • If you have used an LLM/AI to help with code or assets, you must disclose this.
    This change was authored not by me but by Liliana Marie Prikler; as far as I know they haven't used AI to author it.

To do

This PR is a Ready for Review.

How to test

I'm testing in an environment set up by Guix, via e.g.:

$ LUANTI_GAME_PATH=/home/maxim/.guix-profile/share/luanti/games LUANTI_WORLD_PATH='/tmp/worlds' luanti --verbose
# or 
$ MINETEST_GAME_PATH=/home/maxim/.guix-profile/share/luanti/games MINETEST_WORLD_PATH='/tmp/worlds' luanti --verbose

@wsor4035 wsor4035 added @ Startup / Config / Util @ Engine Core What happens inside the very engine and removed @ Engine Core What happens inside the very engine labels Jan 8, 2026
cx384
cx384 reviewed Jan 8, 2026
View reviewed changes
@apteryks apteryks force-pushed the add-support-for-luanti-environment-variables branch from ac625ee to 79ddbc4 Compare January 8, 2026 04:12
@apteryks apteryks requested a review from cx384 January 8, 2026 04:13
sfan5
sfan5 reviewed Jan 8, 2026
View reviewed changes
@Zughy Zughy added the Action / change needed Code still needs changes (PR) / more information requested (Issues) label Jan 8, 2026
Add support for LUANTI_GAME_PATH and LUANTI_WORLD_PATH
ae31211 
Also fix duplicate warnings.

* src/content/subgames.cpp (getSubgamePathEnv): Deprecate
MINETEST_SUBGAME_PATH in favor of LUANTI_GAME_PATH.
(getWorldPathEnv): Deprecate MINETEST_WORLD_PATH in favor of
LUANTI_WORLD_PATH.
(getEnvModPaths): Deprecate MINETEST_MOD_PATH in favor of
LUANTI_MOD_PATH.

Co-authored-by: Liliana Marie Prikler <[email protected]>
@apteryks apteryks force-pushed the add-support-for-luanti-environment-variables branch from 79ddbc4 to ae31211 Compare January 9, 2026 01:38
@apteryks apteryks requested a review from sfan5 January 9, 2026 01:38
@cx384 cx384 removed the Action / change needed Code still needs changes (PR) / more information requested (Issues) label Jan 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cx384 cx384 Awaiting requested review from cx384

@sfan5 sfan5 Awaiting requested review from sfan5

Assignees

No one assigned

Labels

@ Startup / Config / Util

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@apteryks @sfan5 @cx384 @wsor4035 @Zughy