Add new gettext entries for game settings#16862
Add new gettext entries for game settings#16862alrito28 wants to merge 1 commit intoluanti-org:masterfrom
Conversation
add parameter to translate minetest_games
|
MTG translations do not belong in engine .po files. |
|
"MTG translations do not belong in engine .po files." Do you have any ideas ? Because for me, that's the solution that works :) |
|
Please explain why removing the separation between the engine and mods/games is a justifiable solution to begin with. If you can't explain this then I maintain my rejection on this PR. |
I know that this approach works, but I did not question that to begin with. What I did question was why your current approach is justifiable, which you so far failed to explain. In particular, you did not justify the consequences of your approach, i.e. that it effectively removes the separation between engine translations and translations for mods/games. This leads to a number of problems:
These problems can be avoided entirely be addressing #9070 properly. Not to mention that |
In case #16862 (comment) was not clear enough: I can see the issue you are trying to solve, and I do not question the goal of supporting translations; what I asked you to explain is why you chose to do so by directly adding game-/mod-related strings into the engine and why you consider this to be acceptable from the perspective of maintenance (among other things). In my previous comment, I have listed a number of issues that would be created by your PR; these issues would not exist if we chose to implement #9070 (comment) instead, which is what I am trying to do in #16865. So please explain why you consider it acceptable to have the follow-up issues I mentioned in #16862 (comment); and the answer should be more than "this PR works". |
As I explained in #16862 (comment), this "simple" solution has the problem that it introduces maintenance burden in the future for everyone:
This burden is unwarranted in that this can be entirely avoided by properly allowing mods and games to provide their own translations for settings, as suggested in #9070 (comment). The question is why you consider your "simple" PR acceptable given the above issues.
Then please provide a solution to what I wrote above.
If you believe my current opinion is uninformed you can write that out explicitly. |
|
I don't have a solution, and you're right. I may be rushing, but I understand as time goes by. Do what you have to do, but in the meantime, I don't see my language in the settings :( |

add parameter to translate minetest_games
Add compact, short information about your PR for easier understanding:
To do
This PR is a Work in Progress / Ready for Review.
How to test