Open
Conversation
SmallJoker
reviewed
Mar 12, 2026
SmallJoker
reviewed
Mar 12, 2026
| while (!done.empty()) { | ||
| // this looks stupid, but is a simple and correct way to chunk them | ||
| std::vector<u32> part; | ||
| while (!done.empty() && part.size() < 255) { |
Member
There was a problem hiding this comment.
This changes FIFO to FILO. Late requests are processed first. This is however not an issue, right?
Contributor
|
FWIW, the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bug fix PR. It fixes bugs.
1&2: fixes #17012
3: fixes #17002
4: fixes #16554
5: fixes #16989
To do
This PR is Ready for Review.
How to test
code:
dropped:register_allow_player_inventory_action. dropping the item should cause it to change colorcore.get_translated_stringcall breaks server translation #17002/asdf, it should load twice and show no warning at the client or server (make sure file is not in cache already)