Translation of the game description

[alrito28]

I replicated what the Glitch does in the game, and it works.

[alrito28]

We'll see. What I put in the pull request can be taken into account because it works.

[sfan5]

I am requesting this to be changed before we can merge the PR.

[alrito28]

Where should I move it?

[sfan5]

Try if it can work inside the default mod.

[alrito28]

Oh, okay, in mods/default/locale/default.fr.tr ?

[alrito28]

It works, you can merging :)

[sfan5]

Oh, okay, in mods/default/locale/default.fr.tr ?

No, that would get overwritten when automatically updating the files. The description should use a different textdomain.

[alrito28]

[alrito28]

What are you waiting for to accept my work?

What works, works, so go ahead.

[sfan5]

@luanti-org/game ping
Personally I am against creating a dummy mod just to store the game description file, if it can be avoided.

[SmallJoker]

The idea of translating is good. It's tricky to say how this should be implemented. I can see the following options: (preferred on top)

1. Extend the Luanti API to allow translating user-facing meta information (game and modpack descriptions, help dialogues or whatever might be added in the future). The locale would have to be put in a specific directory, however that would need blacklisting in the mod list, as we would not want to attempt to load a mod called locale.
2. I assume that each game (or modpack for this matter) has a central/core mod, hence the translation could be put there but using another textdomain. However, it would be an unreasonable effort for the translation script to find out which mod that would be.

I'd also appreciate more ideas on this topic.

EDIT: Option 2 is currently possible due to luanti-org/luanti#12208, however, that does AFAIK also predate the translation update script, thus there were no such concerns.

[sfan5]

Wouldn't just putting it into mods/default/locale/game_description.fr.tr work?
Then it's not an extra mod but the translation script would ignore it.

[alrito28]

It's simple, it works for me. I based this on Glitch. Here is the link to the Glitch sources: https://codeberg.org/Wuzzy/Glitch

[sfan5]

Sorry for the delay. I moved the translation file as I suggested and verified that it works.

[SmallJoker]

LGTM