[manual squash] Update Bucket mod - #3247
Open
tenplus1 wants to merge 5 commits into
Open
Conversation
Initial minetest. to core. tidy
Member
|
My personal opinion is that we shouldn't be changing |
Contributor
Author
|
@sfan5 - I'll only do it if actually changing the code within. |
remove whitespace
Member
|
But what did you actually change? The diff is huge and this is hard to review. |
Contributor
Author
|
@sfan5 - The main changes were in the "Simplify" part above with some early returns set and redo of the force_renew, also using remove_node instead of setting to air. |
Early return for nil itemname, default position is pointed_thing.below unless not buildable_to
SmallJoker
reviewed
May 24, 2026
SmallJoker
left a comment
Member
There was a problem hiding this comment.
Looks good aside from the comments. The adjustments will need manual squashing. Otherwise it'll be very difficult to differentiate renaming vs restructuring changes.
Added tabs and removed inv check.
SmallJoker
approved these changes
May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial minetest. to core. tidy
Simplify: Early return checks, nil check, replace set_node air with remove_node (empty bucket).
Simplify2: Early return checks, nil check, default below position with check for above (filled bucket).