Skip to content

[manual squash] Update Bucket mod - #3247

Open
tenplus1 wants to merge 5 commits into
luanti-org:masterfrom
tenplus1:patch-5
Open

[manual squash] Update Bucket mod#3247
tenplus1 wants to merge 5 commits into
luanti-org:masterfrom
tenplus1:patch-5

Conversation

@tenplus1

@tenplus1 tenplus1 commented May 16, 2026

Copy link
Copy Markdown
Contributor

Initial minetest. to core. tidy

Simplify: Early return checks, nil check, replace set_node air with remove_node (empty bucket).

Simplify2: Early return checks, nil check, default below position with check for above (filled bucket).

Initial minetest. to core. tidy
@tenplus1 tenplus1 changed the title Initial minetest. to core. tidy Update Bucket mod May 16, 2026
@sfan5

sfan5 commented May 16, 2026

Copy link
Copy Markdown
Member

My personal opinion is that we shouldn't be changing minetest to core in existing code. It's busywork.

Add early returns and simplify force_renew check.
@tenplus1

tenplus1 commented May 16, 2026

Copy link
Copy Markdown
Contributor Author

@sfan5 - I'll only do it if actually changing the code within.

remove whitespace
@sfan5

sfan5 commented May 17, 2026

Copy link
Copy Markdown
Member

But what did you actually change? The diff is huge and this is hard to review.

@tenplus1

Copy link
Copy Markdown
Contributor Author

@sfan5 - The main changes were in the "Simplify" part above with some early returns set and redo of the force_renew, also using remove_node instead of setting to air.

Early return for nil itemname, default position is pointed_thing.below unless not buildable_to

@SmallJoker SmallJoker left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good aside from the comments. The adjustments will need manual squashing. Otherwise it'll be very difficult to differentiate renaming vs restructuring changes.

Comment thread mods/bucket/init.lua Outdated
Comment thread mods/bucket/init.lua Outdated
@SmallJoker SmallJoker changed the title Update Bucket mod [manual squash] Update Bucket mod May 24, 2026
Added tabs and removed inv check.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants