Fix #2136: Include read-only/read-write attribute info in type mismatch errors #2139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pe mismatch errors When assigning a read-only property to a read-write property type, the error message now includes information about the property attributes, making it clear that the subtyping check failed because the property is read-only in the former type but read-write in the latter type. Example error message: 'accessing hello results in umber in the former type (where hello is read-only) and umber in the latter type (where hello is read-write)'
…type pack instantiation When extra types are materialized into a type pack during function type instantiation, the type pack needs to be properly structured for generalization. This fix ensures that extra types are handled correctly before calling instantiateFunctionType, similar to how saturateArguments handles them. Fixes assertion failure: isKnown(params.polarity) in Generalization.cpp
Contributor
|
Thanks! 
Oh my, that's quite the chain! Also, I think you need to put these changes under a FFlag, but I'm not sure |
Author
HAHAHAHAH I was just trying to fix it first |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2136. When assigning a read-only property to a read-write property type, the error message now includes information about the property attributes. Previously, the error would say
numberis not a subtype ofnumberwhich was confusing. Now it clearly states that the property is read-only in the former type but read-write in the latter type, making it obvious why the subtyping check failed.