Feature: Lute Config and Module Resolvers#535
Conversation
Vighnesh-V
left a comment
Vighnesh-V
left a comment
There was a problem hiding this comment.
Looks good - just some small changes.
…github.com/luau-lang/lute into annietang/lute_config_and_module_resolvers
| namespace Luau | ||
| { | ||
|
|
||
| // Based on LuteConfigResolver in tc.cpp. |
There was a problem hiding this comment.
Wait are we just duplicating this right now?
There was a problem hiding this comment.
nah this one is more comprehensive than tc.cpp
There was a problem hiding this comment.
it's not exactly the same @Vighnesh-V did you say we wanted to use this one in configresolver instead of the implementation in tc.cpp?
There was a problem hiding this comment.
I would have guessed we were pulling these file/config resolvers out into their own files so that tc.cpp could use them.
There was a problem hiding this comment.
yea I think the version in this PR is the tc.cpp LuteConfigResolverwith the addition of handling.config.luau(bc thetc.cpponly handles.luaurc`
|
Sorry, I disabled auto-merge—I have some comments incoming |
3 participants
Split from #531 and exposes a Config and Module resolvers for Lute in separate files for ease of use and readability!
Have tests for everything except
resolveModule