Conversation
Preview via Cloudflare R2 Storage⚡️WordPress Playground Preview I will update this comment with the latest preview links as you push more changes to this PR. Note The preview sites are created using WordPress Playground. You can add content, edit settings, and test the pull request as you would on a real site, but please note that changes are not saved between sessions. |
ajitbohra
left a comment
ajitbohra
left a comment
There was a problem hiding this comment.
left some sugestion and feedback
| } | ||
| } | ||
| add_action( 'enqueue_block_assets', 'blablablocks_formats_enqueue_assets' ); | ||
| add_action('enqueue_block_assets', 'blablablocks_formats_enqueue_assets'); |
There was a problem hiding this comment.
The extra spacing within brackets seems to be removed in the PR. Maybe after removing prettierrc. Can we check this?
There was a problem hiding this comment.
I understand that we have removed phpcs.xml.dist since we have only one simple PHP file. However, I am seeing removal of spaces even in our JS files.
There was a problem hiding this comment.
@nagesh, we can format the code anytime by simply running the command npm run format. Alternatively, we can use npm run lint:js, which will also format the code and display an errors.
…s for Infotip format
…ltip on content change
…on in Marker Edit component
ajitbohra
left a comment
ajitbohra
left a comment
There was a problem hiding this comment.
Looks good to ship 👍
Let's merge this and address PHP/JS code linting and formatting in development separately.
3 participants
Summary
Refactored code for better structure and maintainability.
Changes
1.0.0.prettierrc.jsand added"prettier": "@wordpress/prettier-config"in package.jsonphpcs.xml.distas PHP usage is minimal (only enqueuing)blablablocks-marker→tatva-markerblablablocks-infotip→tatva-infotipformat.jsonnow directly importing ./marker and ./infotip inindex.jstextlabel from the infotip’s Text tabconstants.jsfor shared configuration valuesutils.jsfor helper functionsRelated Issue
Closes #41 #54