Conversation
Preview via Cloudflare R2 Storage⚡️WordPress Playground Preview I will update this comment with the latest preview links as you push more changes to this PR. Note The preview sites are created using WordPress Playground. You can add content, edit settings, and test the pull request as you would on a real site, but please note that changes are not saved between sessions. |
nagpai
left a comment
nagpai
left a comment
There was a problem hiding this comment.
I did a review with a few minor suggestions. The changes work very well though when I tested on a Playground site!
| isActive, | ||
| }) { | ||
| const name = 'blablablocks/gradient-text'; // Format type name | ||
| const PREFIX = 'background:'; |
There was a problem hiding this comment.
| const PREFIX = 'background:'; | |
| const PREFIX = 'background-image:'; |
Minor and non-blocking: Should we make the attribute more specific, since we seem to be manipulating the background-image property?
There was a problem hiding this comment.
Should we choose to keep the custom clear button, it shows enabled when there is no gradient selection done. It should show grayed when there is no selection done yet.
| __next40pxDefaultSize | ||
| > | ||
| {__('Clear', 'blablablocks-formats')} | ||
| </Button> |
There was a problem hiding this comment.
I noticed that we are not using the Clear button provided within the GradientPicker component and use a custom Clear button instead. I did a test by reverting to the GradientPicker built-in clear button ( setting clearable to true ), it seems to work fine.
Is there any reason we are overriding that?
3 participants
Summary
This PR introduces a new gradient text format that enhances visual appeal and allows for more engaging typography styles.
Screenshots / Screen Recording / Logs
Screen.Recording.2025-08-08.at.5.04.33.PM.1.mov