Don't replace Node and Element types with any#61
Open
jespertheend wants to merge 2 commits intolucacasonato:mainfrom
Open
Don't replace Node and Element types with any#61jespertheend wants to merge 2 commits intolucacasonato:mainfrom
Node and Element types with any#61jespertheend wants to merge 2 commits intolucacasonato:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure what the reason was to remove
ElementandNodetypes, so this PR might be uncalled for.My projects already have
"dom"added to the compilerOptions so I needed this anyway, so I figured I might as well submit a PR.I reckon any project using puppeteer will benefit from adding dom types to the compiler options anyway, and deno doesn't type check remote modules in
deno runby default since 1.22. So I don't think there should be any issues in bringing these types back.Fixes #54