fix(oauth): fixed generic oauth provider#539
Open
Mathiasn21 wants to merge 1 commit into
Open
Conversation
Mathiasn21
force-pushed
the
fix/generic-oauth
branch
from
b0464d0 to
8a3597c
Compare
Added Generic OAuth and included this in doc. This fixes issue: lucafaggianelli#538
Mathiasn21
force-pushed
the
fix/generic-oauth
branch
from
8a3597c to
3df0cb2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added Generic OAuth and included this in doc. This fixes issue: #538
Settings was renamed to auth_settings as to not confuse with outer scope.
Removed Microsoft tenant id from generic auth doc. Generic should only care for generic info, not Microsoft.
Introduced method for generic auth. However, providers should've maybe produced by a factory, and enforced via type hints.