🛟 Arrumador: Configure standard tooling and CI#76
Conversation
Co-authored-by: lucasew <15693688+lucasew@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Summary of ChangesHello @lucasew, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on establishing and standardizing the project's development environment and continuous integration practices. It updates Highlights
Changelog
Ignored Files
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces standard tooling and CI configuration using mise. The updates to mise.toml are well-structured, replacing npm with bun for consistency, and using wildcards for lint and fmt tasks which improves maintainability. The addition of a dedicated fmt task for code formatting and the inclusion of the test task in the ci pipeline are excellent improvements to the development workflow. I've added one suggestion to make the fmt task even more comprehensive by including ESLint's auto-fixing capabilities. Overall, these are solid changes.
| "lint:check" = "bun run check" | ||
| lint = { depends = ["lint:eslint", "lint:prettier", "lint:check"] } | ||
| lint = { depends = ["lint:*"] } | ||
| "fmt:prettier" = "prettier --write ." |
There was a problem hiding this comment.
To make the fmt task more comprehensive, consider also running eslint --fix. This would handle auto-fixable linting issues, complementing Prettier's formatting. The fmt task, which depends on fmt:*, would then automatically run both fixes.
| "fmt:prettier" = "prettier --write ." | |
| "fmt:eslint" = "eslint . --fix" | |
| "fmt:prettier" = "prettier --write ." |
Co-authored-by: lucasew <15693688+lucasew@users.noreply.github.com>
Co-authored-by: lucasew <15693688+lucasew@users.noreply.github.com>
Co-authored-by: lucasew <15693688+lucasew@users.noreply.github.com>
Co-authored-by: lucasew <15693688+lucasew@users.noreply.github.com>
Co-authored-by: lucasew <15693688+lucasew@users.noreply.github.com>
|
Deployment failed with the following error: Learn More: https://vercel.com/lucas-eduardos-projects-60743954?upgradeToPro=build-rate-limit |
Analyzed closed PRs #62, #63, #67, #68, #70, #73, #75, #76, #78, #79, #85, #86 and extracted recurring patterns of rejection to append them to `.jules/CONSISTENTLY_IGNORED.md`. Added rules for Automated Codegen PR workflows, Wildcard Mise Task Dependencies, Redundant Color Normalization in Store, and Sanitizing Filename Fallback in Theme Loader. Also fixed CI issues by removing an unused import in `src/hooks.client.ts` and deleting `src/instrumentation.server.ts` to resolve build errors with SvelteKit adapter-auto.
Analyzed closed PRs #62, #63, #67, #68, #70, #73, #75, #76, #78, #79, #85, #86 and extracted recurring patterns of rejection to append them to `.jules/CONSISTENTLY_IGNORED.md`. Added rules for Automated Codegen PR workflows, Wildcard Mise Task Dependencies, Redundant Color Normalization in Store, and Sanitizing Filename Fallback in Theme Loader. Also fixed CI issues by removing an unused import in `src/hooks.client.ts` and deleting `src/instrumentation.server.ts` to resolve build errors with SvelteKit adapter-auto. Finally, ran Prettier to fix formatting issues in remaining json, js, and ts config files that were causing the `fmt` check to fail.
Analyzed closed PRs #62, #63, #67, #68, #70, #73, #75, #76, #78, #79, #85, #86 and extracted recurring patterns of rejection to append them to `.jules/CONSISTENTLY_IGNORED.md`. Added rules for Automated Codegen PR workflows, Wildcard Mise Task Dependencies, Redundant Color Normalization in Store, and Sanitizing Filename Fallback in Theme Loader. Also fixed CI issues by removing an unused import in `src/hooks.client.ts` and deleting `src/instrumentation.server.ts` to resolve build errors with SvelteKit adapter-auto. Finally, ran Prettier to fix formatting issues in remaining json, js, and ts config files that were causing the `fmt` check to fail.
Configured mise tasks for linting, formatting, testing, and CI. Created a single GitHub Actions workflow '.github/workflows/autorelease.yml' for continuous integration and release.
Changes:
mise.tomlto include wildcard dependencies forlintandfmt.fmtandfmt:prettiertasks.citask to depend onlint,test, andbuild.codegentask to usebun..github/workflows/autorelease.ymlwith Install, Codegen, PR, CI, Release, and Artifacts steps..github/workflows/autorelease.yml.PR created automatically by Jules for task 13412118545808642502 started by @lucasew