Skip to content
This repository was archived by the owner on Dec 1, 2017. It is now read-only.

item selection allowed on disabled views #206

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
79 changes: 40 additions & 39 deletions core/src/main/java/org/lucasr/twowayview/ItemSelectionSupport.java
Original file line number Diff line number Diff line change
Expand Up @@ -475,51 +475,52 @@ private class TouchListener extends ClickItemTouchListener {

@Override
boolean performItemClick(RecyclerView parent, View view, int position, long id) {
final Adapter adapter = mRecyclerView.getAdapter();
boolean checkedStateChanged = false;

if (mChoiceMode == ChoiceMode.MULTIPLE) {
boolean checked = !mCheckedStates.get(position, false);
mCheckedStates.put(position, checked);

if (mCheckedIdStates != null && adapter.hasStableIds()) {
if (view.isClickable() && view.isEnabled()) {
final Adapter adapter = mRecyclerView.getAdapter();
boolean checkedStateChanged = false;

if (mChoiceMode == ChoiceMode.MULTIPLE) {
boolean checked = !mCheckedStates.get(position, false);
mCheckedStates.put(position, checked);

if (mCheckedIdStates != null && adapter.hasStableIds()) {
if (checked) {
mCheckedIdStates.put(adapter.getItemId(position), position);
} else {
mCheckedIdStates.delete(adapter.getItemId(position));
}
}

if (checked) {
mCheckedIdStates.put(adapter.getItemId(position), position);
mCheckedCount++;
} else {
mCheckedIdStates.delete(adapter.getItemId(position));
mCheckedCount--;
}
}

if (checked) {
mCheckedCount++;
} else {
mCheckedCount--;
}

checkedStateChanged = true;
} else if (mChoiceMode == ChoiceMode.SINGLE) {
boolean checked = !mCheckedStates.get(position, false);
if (checked) {
mCheckedStates.clear();
mCheckedStates.put(position, true);

if (mCheckedIdStates != null && adapter.hasStableIds()) {
mCheckedIdStates.clear();
mCheckedIdStates.put(adapter.getItemId(position), position);

checkedStateChanged = true;
} else if (mChoiceMode == ChoiceMode.SINGLE) {
boolean checked = !mCheckedStates.get(position, false);
if (checked) {
mCheckedStates.clear();
mCheckedStates.put(position, true);

if (mCheckedIdStates != null && adapter.hasStableIds()) {
mCheckedIdStates.clear();
mCheckedIdStates.put(adapter.getItemId(position), position);
}

mCheckedCount = 1;
} else if (mCheckedStates.size() == 0 || !mCheckedStates.valueAt(0)) {
mCheckedCount = 0;
}

mCheckedCount = 1;
} else if (mCheckedStates.size() == 0 || !mCheckedStates.valueAt(0)) {
mCheckedCount = 0;

checkedStateChanged = true;
}

if (checkedStateChanged) {
updateOnScreenCheckedViews();
}

checkedStateChanged = true;
}

if (checkedStateChanged) {
updateOnScreenCheckedViews();
}

return false;
}

Expand Down