Skip to content
This repository was archived by the owner on Dec 2, 2025. It is now read-only.

Conversation

@aalbertoni
Copy link
Contributor

@aalbertoni aalbertoni commented Dec 17, 2023

Summary by CodeRabbit

  • Bug Fixes
    • Refined the process of retrieving account statement information to ensure accuracy and stability.

@coderabbitai
Copy link

coderabbitai bot commented Dec 17, 2023

Walkthrough

The update in the pyitau codebase refines the way a property retrieves data from HTML. Specifically, it tweaks the full_statement_op property to more accurately target an anchor (<a>) tag based on a specific href attribute value. This ensures the property fetches the correct "data-op" attribute, likely improving the reliability of the operation it's designed to perform.

Changes

File Change Summary
pyitau/pages.py Modified full_statement_op to fetch "data-op" from a specific <a> tag with a defined href.

🐇✨
In the code's woven tapestry,
A rabbit tweaked the property.
With a hop and a skip, the <a> tag's found,
Ensuring the data-op's solid and sound. 🌟

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ?


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • You can reply to a review comment made by CodeRabbit.
  • You can tag CodeRabbit on specific lines of code or files in the PR by tagging @coderabbitai in a comment.
  • You can tag @coderabbitai in a PR comment and ask one-off questions about the PR and the codebase. Use quoted replies to pass the context for follow-up questions.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 1

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between ad9976c and 7f07f84.
Files selected for processing (1)
  • pyitau/pages.py (1 hunks)

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 7f07f84 and bb4d444.
Files selected for processing (1)
  • pyitau/pages.py (1 hunks)
Files skipped from review due to trivial changes (1)
  • pyitau/pages.py

@property
def full_statement_op(self):
return self._soup.find("a").attrs["data-op"]
return self._soup.find("a", attrs={"href": "javascript:;"}).attrs["data-op"]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test for this fix.

@rodrimaia
Copy link

This PR fixes the get_statements method failing on master. Any chance we could get this merged soon? Thanks! 🙏

@lucasrcezimbra
Copy link
Owner

This PR fixes the get_statements method failing on master. Any chance we could get this merged soon? Thanks! 🙏

I'll fix the tests and merge it.

In the meantime, you can try to use get_statements_from_month. I'm using it daily (here) and didn't have any issues.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants