fix(PidBasedController) check PID maps to running process #767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucatume
force-pushed
the
v4-better-pid-check
branch
from
9e78108 to
7bab32c
Compare
This fixes the issue where one of the managed processes (Chromedriver, PHP built-in server or MySQL server) would be killed by the system or user outside of wp-browser control leaving an orphaned PID file pointing at a no-more-running process.
lucatume
force-pushed
the
v4-better-pid-check
branch
from
7bab32c to
8993ad5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue where one of the managed processes (Chromedriver,
PHP built-in server or MySQL server) would be killed by the system or
user outside of wp-browser control leaving an orphaned PID file pointing
at a no-more-running process.