LDEV-1697 tighten dotted cfc resolution + contextual throw with source CFC/property#50
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://luceeserver.atlassian.net/browse/LDEV-1697
getCFC(name)fallback inSessionFactoryData.getEntityByCFCName(both 2-arg and 3-arg variants). A dotted reference likecfc="ns.Name"now requires the matching/nsmapping in the current app — previously a registeredNameentity in any namespace would resolve, iteration-order-dependent (passed Windows, failed Linux).HBMCreator.setForeignEntityNamenow uses the non-throwing 3-arg variant and throws contextual on null:Cannot resolve entity reference [ns.Name] on property [foo] of [...]. Names the source CFC + property so the misconfiguration is immediately diagnosable./childnsmapping correctly throws with the contextual message; (2) parent declaring the mapping (viaurl.withMapping=true) resolves andentityNewsucceeds.Matches ACF behaviour (ACF already throws this scenario per the LDEV-1697 tracker doc).