-
-
Notifications
You must be signed in to change notification settings - Fork 717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add lucide package for Astro #2665
base: main
Are you sure you want to change the base?
Conversation
Added or changed iconsIcons as codeWorks for: const PictureInPictureIcon = createLucideIcon('PictureInPicture', [
["path",{"d":"M2 10h6V4"}],
["path",{"d":"m2 4 6 6"}],
["path",{"d":"M21 10V7a2 2 0 0 0-2-2h-7"}],
["path",{"d":"M3 14v2a2 2 0 0 0 2 2h3"}],
["rect",{"width":"10","height":"7","x":"12","y":"14","rx":"1"}]
]) |
Is there any update on this PR? It has been almost 1.5 months without any further progress. |
Since @Aviortheking seems unavailable, could we maybe publish the package as I'm in no rush, I just want to know your thoughts about an alternative path to get this over the line. cc @ericfennis |
No I'm thinking of releasing it with the lucide scope anyways. |
Even better 😄 So I'll work on replacing mentions of the package to |
@MoustaphaDev Awesome! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice almost ready!
Some paths need some adjustment with the new naming
set correct path for package in actions
Co-authored-by: Eric Fennis <[email protected]>
…nto feat/astro
Made the suggested changes! |
TODOs:
@lucide/astro
and revise PR description afterWhat is the purpose of this pull request?
Description
Add a new package for first-class Astro support.
(outdated) Here's the demo project using both the legacy and rewritten package: demo project
See #2665 (comment) for more details.
Before Submitting