Skip to content

InstrumentationClassFinder: Don't give counter-warning for dynamic agent if dynamic agents are enabled #553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ByThePowerOfScience wants to merge 1 commit into
base: master
Choose a base branch
from
Open

InstrumentationClassFinder: Don't give counter-warning for dynamic agent if dynamic agents are enabled #553

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion ...mmon/src/main/java/me/lucko/spark/common/util/classfinder/InstrumentationClassFinder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
import org.checkerframework.checker.nullness.qual.Nullable;

import java.lang.instrument.Instrumentation;
import java.lang.management.ManagementFactory;
import java.util.HashMap;
import java.util.Map;
import java.util.logging.Level;
Expand All @@ -39,11 +40,18 @@ public class InstrumentationClassFinder implements ClassFinder {

private static boolean warned = false;

/**
* This is the JVM flag the warning tells you to use.
*
* <p>If this is set, Java will never give an admonition, so we shouldn't give a counter-admonition.
*/
private static final boolean NO_WARNING_NEEDED = ManagementFactory.getRuntimeMXBean().getInputArguments().contains("-XX:+EnableDynamicAgentLoading");

private static Instrumentation loadInstrumentation(SparkPlugin plugin) {
Instrumentation instrumentation = null;
try {
instrumentation = ByteBuddyAgent.install();
if (!warned && JavaVersion.getJavaVersion() >= 21) {
if (!NO_WARNING_NEEDED && !warned && JavaVersion.getJavaVersion() >= 21) {
warned = true;
plugin.log(Level.INFO, "If you see a warning above that says \"WARNING: A Java agent has been loaded dynamically\", it can be safely ignored.");
plugin.log(Level.INFO, "See here for more information: https://spark.lucko.me/docs/misc/Java-agent-warning");
Expand Down