Skip to content

Conversation

@russ
Copy link
Contributor

@russ russ commented Jun 17, 2025

Purpose

Supporting different javascript runtime options. npm, yarn, and bun.
This is in tandem with luckyframework/lucky_cli#889

Description

I'm not a huge fan of how this is done. I would love to see a different approach.

Checklist

  • - An issue already exists detailing the issue/or feature request that this PR fixes
  • - All specs are formatted with crystal tool format spec src
  • - Inline documentation has been added and/or updated
  • - Lucky builds on docker with ./script/setup
  • - All builds and specs pass on docker with ./script/test

 This is in tandem with luckyframework/lucky_cli#889

 I'm not a huge fan of how this part has to be done. I would love a
 different approach.
@jwoertink
Copy link
Member

So the main question here is, if we just got rid of the browser-sync (which may not even be working, and have been broken for some time), then none of this becomes required. The swap out becomes a lot easier to handle.

We wouldn't lose the auto-reload on the Crystal side because that's still handled by the websocket reloader which is default anyway. Though, I'm not sure if any of the javascript or css files are watched and reloaded on change with that...

@russ
Copy link
Contributor Author

russ commented Jul 9, 2025

So I think was covered in #1982 ? Much better I might add.

@jwoertink
Copy link
Member

Yeah, I think this PR was only needed to work around browser-sync, but since we're basically ripping that out, then none of this should be needed.

@jwoertink jwoertink closed this Jul 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants