Preprocessing change underscore_ to x_ and require map key. (opensearch-project#216)

* Preprocessing change underscore_ to x_

Signed-off-by: xil <fridalu66@gmail.com>

Author: lucy66hw

CHANGELOG.md

@@ -5,6 +5,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
 ## [Unreleased]
 ### Added
 - Add .pyi type hints to the python wheel ([#253](https://github.com/opensearch-project/opensearch-protobufs/pull/253))
+- Preprocessing: change prefix from underscore_ to x_ and require map key ([#216](https://github.com/opensearch-project/opensearch-protobufs/pull/216))
 
 ### Changed
 - Revert bulk response back to without error response ([#256](https://github.com/opensearch-project/opensearch-protobufs/pull/256))

tools/proto-convert/src/Sanitizer.ts

@@ -7,6 +7,7 @@ import {traverse} from "./utils/OpenApiTraverser";
  * and renaming schema definitions.
  */
 export class Sanitizer {
+  private static readonly META_PREFIX = "x";
   public sanitize(spec: any): any {
     this.sanitize_ref(spec);
     this.sanitize_spec_name(spec as OpenAPIV3.Document);
@@ -73,7 +74,7 @@ export class Sanitizer {
       onResponseSchema: (schema) => this.sanitize_schema(schema),
       onParameter: (param, _paramName) => {
         if (!('$ref' in param) && param.name && param.name.startsWith('_')) {
-          param.name = `underscore${param.name}`;
+          param.name = Sanitizer.META_PREFIX + param.name;
         }
       }
     });
@@ -93,7 +94,7 @@ export class Sanitizer {
   public rename_properties_name(properties: Record<string, OpenAPIV3.SchemaObject>) {
     for (var propName in properties) {
       if(propName.startsWith("_")) {
-        const newPropName = "underscore" + propName;
+        const newPropName = Sanitizer.META_PREFIX + propName;
         properties[newPropName] = properties[propName];
         delete properties[propName];
       }
@@ -104,7 +105,7 @@ export class Sanitizer {
     for (var index in requireList) {
       var propName = requireList[index];
       if(propName.startsWith("_")) {
-        requireList[index] = "underscore" + propName;
+        requireList[index] = Sanitizer.META_PREFIX + propName;
       }
     }
   }

tools/proto-convert/src/SchemaModifier.ts

@@ -224,7 +224,8 @@ export class SchemaModifier {
                 [DEFAULT_MAP_KEY]: {
                     type: "string"
                 }
-            }
+            },
+            required: [DEFAULT_MAP_KEY]
         };
     }