WIP: Remove torchtext dependency#4038
Closed
mhabedank wants to merge 4 commits into
Closed
Conversation
mhabedank
force-pushed
the
remove_torchtext
branch
from
October 29, 2024 21:45
786075d to
92a3ec0
Compare
mhabedank
marked this pull request as ready for review
November 16, 2024 14:40
mhabedank
requested review from
Infernaught,
alexsherstinsky,
arnavgarg1,
geoffreyangus,
jeffkinnison,
justinxzhao,
tgaddair and
w4nderlust
as code owners
November 16, 2024 14:40
Collaborator
Author
|
this is merged into #4041 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
torchtext is deprecated but used for some tokenizers in Ludwig.
This PR will remove the dependency.
Related to
#4031
#4032
#4033
#4034
#4035