Updated to allow different data attributes if required #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated to allow for a params object without affecting the original
API. You can now pass an object as the first param. In doing so you can
now update what attribute Unveil will target for an image’s src with
the following code.
$(element).unveil({
threshold: 10,
attrib: 'data-unveil-src',
retinaAttrib: 'data-unveil-retina-src'
});
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to use Unveil in an Angular project but since Angular takes control of the data-src attribute I needed to be able to change the data attribute Unveil targets for an image src.
This can be done with the following syntax.
You should be able to supply one or the other or neither and Unveil will continue to work as it always has.