Feat: real time video show - #94
Conversation
ef7bce1 to
e93b805
Compare
|
Videos kept playing after closing the video settings dialog so I connected the play/stop to signals Unfortunately there is still an increased memory usage caused by the preview, likely a Qt bug. The plasma 5 version of this wallpaper also had it and I removed the previews because of that. You can quickly test by opening the preview for multiple videos and let them play for some seconds, the memory usage for It seems some of the memory is freed after some time but not all of it. Can you verify if the same happens on your system? |
|
Same with me. Started at 700Mb RAM usage and increased to 1,3Gb |
…Lobopro/plasma-smart-video-wallpaper-reborn into feat-real-time-video-show
|
What if we open as a separated window and when the window will close we call detroy() |
|
I made this and when I close the preview the RAM usage falls. But open another player raise more than usual RAM usage and when closes again the RAM usage falls less |
|
I found another memory bug. When I switch wallpaper to an image and after change to animated wallpaper again the memory usage raises. I think the solution is add a warning and a button that restart plasma. So the used memory comes back to usual |
Seems to be doing nothing on my system.
Yeah, appears to be the same problem
Rather not risk data loss or something else by exposing a restart button like that. Better just warn the user about the problem and let them choose how to deal with it if they even want/need to. But I am hesitant to merge the previews if this is not fixed or we can't find a workaround |
|
I understand. I will search for another solutions |
|
I tested other things like load video in a webview. But the problem persists, maybe we can open a Issue on Plasma project and wait they resolve this. |
|
I reported it and I have some news. Here is the report It seems the implementation of qtffmpeg doesn't fully de-initialize itself when we destroy the Video item. So it cause high memory usage. I don't know how to solve it or where report exactly, Could you help me? |
Report it to Qt https://bugreports.qt.io in the Multimedia component |
|
Hi, I'm sorry I tried to report it on Qt but this memory leak apparently is caused by a KDE Plasma code and I was not able to report it and I completely forgot to say it |
|
Wasn't it the other way around? In the previous kde bug you shared they said it was most likely a qt bug. Did you report it to them and they said it was on kde, I am confused. |
Fix for #93 bad commit history