Skip to content

Quick Fix due to 2024's Update - #62

Open
martinbros wants to merge 1 commit into
luka1199:masterfrom
martinbros:2024Update
Open

Quick Fix due to 2024's Update#62
martinbros wants to merge 1 commit into
luka1199:masterfrom
martinbros:2024Update

Conversation

@martinbros

@martinbros martinbros commented Jan 17, 2025

Copy link
Copy Markdown

Describe the bug
By 8th December, users will have to have migrated their data to their local device. The data can now be downloaded via the following instructions

 (Android settings -> Location -> Location Services -> Timeline -> Export Timeline Data)

Solution
This is just a quick fix to keep backwards compatibility with old .JSON files and the newly formatted .JSON files which are identified using the keys in the dataset.

I've also added in additional granularity of datetime strings passed in min/max date for my own convenience

…generate maps. Also added functionality to utils.py to allow for more precise min/max date options
@Milooooo1

Milooooo1 commented Mar 12, 2025

Copy link
Copy Markdown

Is it worth adding support for the "activity" and "visit" location positions? This increases the data points on the map? The start position of "activity" seems to correspond with the first index of the "timelinePath" and the end position of "activity" seems to correspond with the "placeLocation" of "visit". So maybe skip activity but add support for visit?

On my device the average distance between two locations in timelinePath seems to be 1.6km with a standard deviation of 5.6km. Although this distance is quite big is it worth interpolating positions between these locations to better show routes on the map?

Comment thread geo_heatmap.py
for entry in dataEntry["timelinePath"]:
# print(entry)
latLon = entry["point"].replace("°", "").split(", ")
coords = (float(latLon[0]), float(latLon[1]))

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, the code didn't work for me until I changed this to coords = (float(latLon[0][:-1]), float(latLon[1][:-1])) - my JSON seems to add a degree symbol to the locations.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And... it's broken again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants