Skip to content

fix(app): improve unmuting of webview #510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
luke-h1 merged 1 commit into from
Mar 1, 2026
Merged

fix(app): improve unmuting of webview #510

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions src/components/StreamPlayer/StreamPlayer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,8 +343,8 @@ function buildTwitchEmbedHtml(options: {
player.addEventListener(Twitch.Player.READY, function() {
post('ready');
if (player.getMuted()) {
var deadline = Date.now() + 800;
var tick = setInterval(function() {
var unmuteDeadline = Date.now() + 5000;
var unmuteTick = setInterval(function() {
var el = null;
try {
var nodes = document.querySelectorAll('button, a, [role=button], [class*="unmute"], [class*="Unmute"]');
Expand All @@ -354,16 +354,16 @@ function buildTwitchEmbedHtml(options: {
}
} catch (e) {}
if (el) {
clearInterval(tick);
clearInterval(unmuteTick);
el.click();
player.setMuted(false);
player.setVolume(1);
} else if (Date.now() > deadline) {
clearInterval(tick);
} else if (Date.now() > unmuteDeadline) {
clearInterval(unmuteTick);
player.setMuted(false);
player.setVolume(1);
}
}, 200);
}, 100);
}
var startWatchingDeadline = Date.now() + 10000;
var startWatchingTick = setInterval(function() {
Expand Down Expand Up @@ -946,7 +946,13 @@ export const StreamPlayer = forwardRef<StreamPlayerRef, StreamPlayerProps>(
setTimeout(retryPlay, 1200);
}
if (!initialMuted && !deferOverlayUntilUserUnmute) {
unmute();
const unmuteDeadline = Date.now() + 5000;
const unmuteInterval = setInterval(() => {
unmute();
if (Date.now() > unmuteDeadline) {
clearInterval(unmuteInterval);
}
}, 100);
}
break;
}
Expand Down