Skip to content

Conversation

@jeengbe
Copy link

@jeengbe jeengbe commented Dec 15, 2025

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you written unit tests?
  • Have you written unit tests that cover the negative cases (i.e.: if bad data is submitted, does the library respond properly)?
  • This PR is associated with an existing issue?

Closing issues

Closes #1817

Potential Problems With The Approach

This will require users to upgrade @types/koa__router -> @koa/router, which may include breaking changes outside the direct scope of tsoa - e.g. in the context or request object.

Test plan

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello there jeengbe 👋

Thank you and congrats 🎉 for opening your first PR on this project.✨

We will review the following PR soon! 👀

@jeengbe
Copy link
Author

jeengbe commented Dec 15, 2025

Perhaps I need to bump the versions for the tests to work in CI? They run just fine locally.

@jeengbe
Copy link
Author

jeengbe commented Dec 16, 2025

I have no idea why this doesn't work. Have you seen this before, WoH?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade @koa/router (breaking change) with v7

1 participant