chore!: upgrade koa/router package#1818
Open
jeengbe wants to merge 2 commits intolukeautry:masterfrom
Open
Conversation
Author
|
Perhaps I need to bump the versions for the tests to work in CI? They run just fine locally. |
Author
|
I have no idea why this doesn't work. Have you seen this before, WoH? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All Submissions:
Closing issues
Closes #1817
Potential Problems With The Approach
This will require users to upgrade
@types/koa__router->@koa/router, which may include breaking changes outside the direct scope of tsoa - e.g. in the context or request object.Test plan