feat: implement tsconfig.json support for compiler options in config #1826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added a new function to read and parse tsconfig.json for compiler options. - Updated the validateCompilerOptions function to merge options from tsconfig.json and tsoa.json, with precedence given to tsoa.json. - error handling for missing tsconfig.json files. - unit tests to validate the new functionality
Author
|
addresses #1825 and makes devx better |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Collaborator
|
Thanks for this PR, I had this in the back of my head. Would you mind checking if we can use: https://github.com/TypeStrong/tsconfig or: for the fallback? Would be more consistent. |
Author
|
I am leaning towards the second option since we wouldn't have to add another dependency. What do you mean by "fallback," though? |
Author
|
*Left unsquashed for more easy reading of the diff |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
options.
tsconfig.json and tsoa.json, with precedence given to tsoa.json.