Skip to content

Conversation

@drqwerty
Copy link

@drqwerty drqwerty commented Mar 5, 2020

Hi.

I needed to rotate images so I added an option for it.

It works quite well, although I have not been able to run the tests due to problems with some packages :(.

TLDR: from me to you :)

@lukechilds
Copy link
Owner

@drqwerty thanks for this, it's a nice addition!

Could you add a usage example and a test like positioning for example: https://github.com/lukechilds/merge-images#positioning

Yeah I'm aware tests are broken atm, I'll fix that as soon as I'm able but not quite sure when that'll be.

Feel free to take it on on your own in the meantime if you want to!

Canvas: undefined,
crossOrigin: undefined
crossOrigin: undefined,
rotate: undefined
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't seem to be using this value anywhere. I think it can be removed.

@RuiSiang RuiSiang mentioned this pull request May 8, 2020
@RuiSiang
Copy link

RuiSiang commented May 8, 2020

I think I found the problem
There has been a change in node-canvas' dependencies
"libjpeg8-dev" should be changed to "libjpeg-dev" or "libjpeg62-turbo-dev"

language: node_js
node_js: node
addons:
  apt:
    sources:
      - ubuntu-toolchain-r-test
    packages:
      - libcairo2-dev
      - libjpeg8-dev
      - libpango1.0-dev
      - libgif-dev
      - g++-4.9
env:
  - CXX=g++-4.9
script: npm run lint && npm test
after_success: npm run coverage
notifications:
  email:
    on_success: never

@RuiSiang RuiSiang mentioned this pull request May 8, 2020
@RuiSiang RuiSiang mentioned this pull request Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants